Skip to content

added ignore hook functionality #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
galbraun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added ignore hook functionality #13

galbraun wants to merge 1 commit into from

Conversation

@galbraun
Copy link
Collaborator

@galbraun galbraun commented Oct 22, 2019

No description provided.

@galbraun galbraun requested a review from DeanLa October 22, 2019 16:28
@DeanLa
Copy link
Member

DeanLa commented Oct 22, 2019

Let's split to 2 PRS

  1. insert attach_hooks into the ledger without added functionality
  2. ignore functionality

@DeanLa
Copy link
Member

DeanLa commented Oct 22, 2019

I thought you wanted to ignore original function for example ignore('concat'). The user will not know the names of the hooks.
Also, code will be much simpler.

@galbraun galbraun added the blocked Blocked until a different PR or issue will be solved label Oct 23, 2019
@galbraun
Copy link
Collaborator Author

galbraun commented Oct 23, 2019

Blocked until #24 will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeanLa DeanLa Awaiting requested review from DeanLa

At least 1 approving review is required to merge this pull request.

Assignees

@DeanLa DeanLa

Labels

blocked Blocked until a different PR or issue will be solved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@galbraun @DeanLa