Open
Conversation
Author
|
I've added support for lifetime=0 from a fork by rimmington. |
|
@dound Is this pull gonna get pushed to master? |
Owner
|
Just reviewed the diff. I think the change to the library itself (gaesessions/init.py) probably wasn't intended to be part of the pull request: |
Author
|
Reverted the change to gaesessions, you are right, it should be reviewed separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi David,
This is the setup.py I've talked to you earlier today.
Please insert your email address in it (or drop that line completely).
Let me know what you think.
I've also added another demo, to show how to quickly download and install the latest version of your library.
If you wish to incorporate it in your project, don't forget to edit the URL in buildout.cfg to point to your repository.