Skip to content

Fix build on latest noVNC#2

Open
zhogov wants to merge 1 commit intodoug-w:masterfrom
zhogov:patch-1
Open

Fix build on latest noVNC#2
zhogov wants to merge 1 commit intodoug-w:masterfrom
zhogov:patch-1

Conversation

@zhogov
Copy link

@zhogov zhogov commented Jul 22, 2020

Updated alpine version. This causes node version to update.
Latest version of alpine didn't have Python installed (that is required by websockify) so also installed Python.

Otherwise docker build fails with:

npm WARN ws@7.3.1 requires a peer of utf-8-validate@^5.0.2 but none was installed.
/root/noVNC/node_modules/fs-extra/lib/index.js:5
  ...require('./fs'),
  ^^^
SyntaxError: Unexpected token ...
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/root/noVNC/utils/use_require.js:6:13)
The command '/bin/sh -c apk --update --upgrade add git bash supervisor nodejs nodejs-npm 	&& git clone https://github.com/novnc/noVNC.git /root/noVNC 	&& cd /root/noVNC 	&& npm install 	&& ./utils/use_require.js --as commonjs --with-app 	&& cp /root/noVNC/node_modules/requirejs/require.js /root/noVNC/build 	&& sed -i -- "s/ps -p/ps -o pid | grep/g" /root/noVNC/utils/launch.sh 	&& apk del git nodejs-npm nodejs' returned a non-zero code: 1```

Updated alpine version. This causes node version to update and noVNC
Otherwise you docker build fails with:
```
npm WARN ws@7.3.1 requires a peer of utf-8-validate@^5.0.2 but none was installed.
/root/noVNC/node_modules/fs-extra/lib/index.js:5
  ...require('./fs'),
  ^^^
SyntaxError: Unexpected token ...
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/root/noVNC/utils/use_require.js:6:13)
The command '/bin/sh -c apk --update --upgrade add git bash supervisor nodejs nodejs-npm 	&& git clone https://github.com/novnc/noVNC.git /root/noVNC 	&& cd /root/noVNC 	&& npm install 	&& ./utils/use_require.js --as commonjs --with-app 	&& cp /root/noVNC/node_modules/requirejs/require.js /root/noVNC/build 	&& sed -i -- "s/ps -p/ps -o pid | grep/g" /root/noVNC/utils/launch.sh 	&& apk del git nodejs-npm nodejs' returned a non-zero code: 1```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant