feat(sentinel): auto-manage multicast publishers#272
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds multicast publisher allowlisting functionality to the sentinel service. When validators are onboarded and granted access passes, they are automatically added to configured multicast publisher groups.
Changes:
- Added
multicast_group_codesconfiguration setting for specifying which multicast groups to auto-join validators to - Implemented multicast group code resolution at startup to convert codes to on-chain PDAs
- Integrated allowlist addition into the validator onboarding flow with proper error handling and metrics
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/sentinel/src/settings.rs | Added multicast_group_codes setting with parsing logic to support comma-separated group codes |
| crates/sentinel/src/main.rs | Added startup logic to resolve multicast group codes to PDAs and pass them to PollingSentinel |
| crates/sentinel/src/sentinel/poller.rs | Added multicast_group_pdas field and integrated allowlist addition into validator onboarding loop with metrics |
| crates/sentinel/src/client/doublezero_ledger.rs | Implemented add_multicast_publisher_allowlist and resolve_multicast_group_codes methods with trait support |
| crates/sentinel/CHANGELOG.md | Added changelog entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
84eb2a4 to
57e4b82
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
57e4b82 to
e188cc7
Compare
Furthermore: - Reject duplicate codes - Add timeout - Add tests
martinsander00
previously approved these changes
Feb 26, 2026
karl-dz
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-joins validators to configured multicast publisher groups on onboarding. At startup, resolves configured group codes to onchain PDAs; on each new access pass, idempotently adds the validator to every configured multicast group's
publisher allowlist.
Changes
Testing