Add parametrized steerable model tests (Transformers backend)#1774
Add parametrized steerable model tests (Transformers backend)#1774kudos07 wants to merge 27 commits intodottxt-ai:mainfrom
Conversation
|
Thanks for opening a PR @kudos07! I think maybe it would make sense to keep those test separated by To me one of the main interest of that would be to check that we do run into tokenizer issues for various models as I've noticed it's often where there are problems. |
|
Update based on review feedback:
Let me know if you'd prefer this test split differently or want it integrated with any existing Transformers test files. |
lmstudio requires Python >= 3.10, added constraint to optional dep.
|
Hi @RobinPicard I’ve pushed an update addressing the feedback from #1774 . What changed
This keeps the scope tight while directly targeting tokenizer robustness across different models, as discussed. |
|
Hi @RobinPicard, whenever you have a moment, please take a look. If any further changes are needed, I’m happy to do the needful! |
|
Can you rebase your branch on main and squash the commits please? Otherwise it's fine, just 2 things I would change
|
|
Hello @RobinPicard, I’ve updated the branch to move the tests into test_transformers.py and removed the conftest changes. A couple of quick clarifications to finalize the structure:
Let me know and I'll adjust accordingly |
I think it would make sense to have a main TEST_MODEL used for all tests + a matrix of more varied models for the parametrized test
In line for the parametrized decorator is fine |
|
Thanks for the feedback @RobinPicard! I’ve moved the parametrized smoke test into All tests are passing locally. Happy to adjust anything further if needed. |
|
No worries at all @kudos07! You just need to rebase your branch on main now and we'll be ready to merge |
|
Hi @RobinPicard — really sorry for the churn and noise earlier. This is my first time navigating a larger rebase / history cleanup here, and I appreciate your patience and guidance throughout. I’ve now replayed the change cleanly on top of The parametrized test lives in Thanks again for the help, and apologies for the back-and-forth. |
|
Closing this draft PR since the work has been replayed cleanly and merged in #1814. Thanks again @RobinPicard for the guidance and review. |
Summary
This draft PR introduces a parametrized test suite for steerable models
covering multiple Hugging Face models under the Transformers backend.
It focuses on one aspect of issue #1717:
Notes