-
Notifications
You must be signed in to change notification settings - Fork 18
Add build/release workflow for Linux, Windows, MacOS, FreeBSD and OpenBSD #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! Thanks a lot for your contribution — this is a great idea, and we fully agree that automating release builds and publishing through GitHub Actions would be very useful. Currently, we build binaries for a wide range of platforms (Windows, macOS, multiple Linux architectures, as well as FreeBSD and OpenBSD), which are available here: Your proposed workflow is a solid starting point, but at the moment we don’t have the capacity to set up support for all the platforms we distribute. That said, we’d really welcome any help in extending the workflow to cover more target systems — using cross-compilation or matrix builds, for example. Thanks again for the initiative — we appreciate it and look forward to improving the release process together! |
abf1977 to
1af2c4d
Compare
|
I have now added jobs to build Linux (amd64, arm64, armhf, i386, mips), Windows (amd64), MacOS (amd64), FreeBSD (amd64), OpenBSD (amd64). I have, however, not tried to run the binaries in their respective environment. |
FaffeF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great, and I think PRs would benefit from automatic builds as well
|
I kind of expected the action to run on this PR, but that probably doesn't kick in until it's merged? Copilot's take: Thank you! |
|
Does this look reasonable? Do you request any further changes before merging? |
|
It is hard to find the time to review your work. But we will try it out when we release the next version of the CLI-client. We are working on a new version at the moment. |
| jobs: | ||
| build-linux: | ||
| name: Build Linux | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI: not sure whether this applies in case of bbk CLI, though building on very latest Ubuntu runner isn't always beneficial. If the tool depends on very latest glibc, it may fail on older, though still supported versions of Ubuntu. A random illustrative example of what I mean: hougesen/mdsf#1322
Add github action release workflow that automatically publishes release with built binary on tags.