Extend ProbingRequestFactory to support Models and Async calls #2985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uestFactory and updated interface, make flow async for futureproofing and maximum extensibility
Author
|
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
IProbingRequestFactory'sCreateRequestAPI to useDestinationStateandClusterStateinstead ofDestinationModel,ClusterModeland makes the method async.Simplifies scenarios where consumers need to access or update health state without relying on internal models.
Allows access to the ID and allows overloads to rely on
ConditionalWeakTablemappings on the objects.This change originated from a discussion with @MihaZupan, and subsequent filing of bug #2890