-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix outdated VS version reference in .gitignore template #52267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This line also applies to VS 2022 and VS 2026. At this point, there's little value in specifying the version, so just remove it to avoid confusion. Also put a space before the next section, as it's unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the .gitignore template by removing outdated Visual Studio version references from a comment. The comment previously referenced "Visual Studio 2015/2017" but now applies to all Visual Studio versions, making it more maintainable and less likely to become outdated again.
Key Changes
- Updated comment to remove specific VS version numbers (2015/2017) from the cache/options directory section
- Added spacing for better organization between unrelated sections
| [Ll]ogs/ | ||
|
|
||
| # Visual Studio 2015/2017 cache/options directory | ||
| # Visual Studio cache/options directory |
Copilot
AI
Dec 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this comment is being updated to remove version-specific references, there are two other similar Visual Studio version references in this file that remain unchanged:
- Line 44: "# Visual Studio 2017 auto generated files"
- Line 379: "# Backup folder for Package Reference Convert tool in Visual Studio 2017"
For consistency with the approach of this PR (removing version-specific references to avoid confusion), consider updating these references as well. These features also apply to newer Visual Studio versions beyond 2017.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot make suggestion comments on this PR so I can apply those changes here rather than requiring a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the changes in b3ed4c0 directly. Ignore the copilot PR.
|
@drewnoakes I've opened a new pull request, #52268, to work on those changes. Once the pull request is ready, I'll request review from you. |
This line also applies to VS 2022 and VS 2026. At this point, there's little value in specifying the version, so just remove it to avoid confusion.
Also put a space before the next section, as it's unrelated.