Skip to content

Conversation

@jjonescz
Copy link
Member

These (2)s in folder names don't seem necessary. cc @kasperk81

@jjonescz jjonescz marked this pull request as ready for review June 20, 2025 11:16
Copilot AI review requested due to automatic review settings June 20, 2025 11:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary (2) suffixes from folder names in the sdk.slnx solution file.

  • Cleans up folder naming by stripping out (2)
  • Applies consistent naming across BlazorWasmSdk, RazorSdk, and WebSdk sections

@kasperk81
Copy link
Contributor

ran dotnet sln migrate command on sdk.sln without any manual edit. is it something which should be fixed in the command? if not, why does it matter for this sln and not the 480 sln files converted in runtime dotnet/runtime#115818?

@baronfel
Copy link
Member

The (2) were there in the original sln as well:

sdk/sdk.sln

Lines 155 to 159 in 8ffe243

Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Sdk (2)", "Sdk (2)", "{F717D467-EF88-49B9-AD67-55FC6350A9DE}"
ProjectSection(SolutionItems) = preProject
src\WebSdk\Publish\Sdk\Sdk.props = src\WebSdk\Publish\Sdk\Sdk.props
src\WebSdk\Publish\Sdk\Sdk.targets = src\WebSdk\Publish\Sdk\Sdk.targets
EndProjectSection

Just a quirk of the sln here, not indicative of a larger issue.

@baronfel baronfel merged commit dff2ba5 into main Jun 20, 2025
32 checks passed
@baronfel baronfel deleted the jjonescz-patch-1 branch June 20, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants