Reduce allocations in LSP completion handling. #82133
Open
+43
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Use discardLargeInstances in ArrayBuilder usage as the matchResultsBuilder array can typically be 1000 entries long which exceeds the ArrayBuilder.PooledArrayLengthLimitExclusive threshold. 2) Replace Linq usage in the method to get rid of some enumerator allocs. 3) Get rid of the SelectAsArray usage, as again, it would end up using an ArrayBuilder that exceeds the ArrayBuilder.PooledArrayLengthLimitExclusive threshold.
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use discardLargeInstances in ArrayBuilder usage as the matchResultsBuilder array can typically be 1000 entries long which exceeds the ArrayBuilder.PooledArrayLengthLimitExclusive threshold.
Replace Linq usage in the method to get rid of some enumerator allocs.
Get rid of the SelectAsArray usage, as again, it would end up using an ArrayBuilder that exceeds the ArrayBuilder.PooledArrayLengthLimitExclusive threshold.
Validation PR didn't show a big improvement, but looking at the Razor C# completion scenario, it only tests bringing up completion inside a using statement. That isn't a scenario where there are a large number (> 1000) of completion items, and thus not a scenario which would hit this codepath. This PR improves allocations in less restrictive completion contexts (ie, typing in a context where accessible types are in the list).