Skip to content

Update Microsoft.Data.Sqlite TFMs: replace netstandard2.0 with net472 #37877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −2
Open

Update Microsoft.Data.Sqlite TFMs: replace netstandard2.0 with net472 #37877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9fd09f
Initial plan
Copilot Mar 6, 2026
b1220ef
Update Microsoft.Data.Sqlite.Core TFMs: replace netstandard2.0 with n…
Copilot Mar 6, 2026
828c311
Add build error when NetMinimum != net10.0 to remind to rename lib di…
Copilot Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Data.Sqlite.Core/Microsoft.Data.Sqlite.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Microsoft.Data.Sqlite.SqliteException
Microsoft.Data.Sqlite.SqliteFactory
Microsoft.Data.Sqlite.SqliteParameter
Microsoft.Data.Sqlite.SqliteTransaction</Description>
<TargetFrameworks>$(NetMinimum);netstandard2.0</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);$(NetFrameworkToolCurrent)</TargetFrameworks>
<MinClientVersion>3.6</MinClientVersion>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<CodeAnalysisRuleSet>Microsoft.Data.Sqlite.Core.ruleset</CodeAnalysisRuleSet>
Expand Down
11 changes: 10 additions & 1 deletion src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Microsoft.Data.Sqlite.SqliteFactory
Microsoft.Data.Sqlite.SqliteParameter
Microsoft.Data.Sqlite.SqliteTransaction</Description>
<IncludeBuildOutput>false</IncludeBuildOutput>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFrameworks>$(NetMinimum);$(NetFrameworkToolCurrent)</TargetFrameworks>
<MinClientVersion>3.6</MinClientVersion>
<PackageTags>SQLite;Data;ADO.NET</PackageTags>
<IncludeSymbols>false</IncludeSymbols>
Expand Down Expand Up @@ -43,4 +43,13 @@ Microsoft.Data.Sqlite.SqliteTransaction</Description>
<Target Name="Compile" />
<Target Name="CopyFilesToOutputDirectory" />

<!-- This is a packaging-only project with no native compilation; suppress the AnyCPU architecture check from SQLitePCLRaw native packages -->
<Target Name="CheckForAnyCPU" />

<Target Name="CheckNetMinimumLibDirectory" BeforeTargets="Build">
<Error
Condition="'$(NetMinimum)' != 'net10.0'"
Text="NetMinimum has changed to '$(NetMinimum)'. Rename the 'lib\net10.0' directory to 'lib\$(NetMinimum)'." />
</Target>
Comment on lines +49 to +53
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CheckNetMinimumLibDirectory target uses BeforeTargets="Build" in a multi-TFM project (TargetFrameworks=$(NetMinimum);$(NetFrameworkToolCurrent)). In MSBuild, BeforeTargets="Build" fires in each inner per-TFM build, causing this error check to run twice (once per TFM). While this is benign since the check is idempotent, using BeforeTargets="DispatchToInnerBuilds" (which fires only once in the outer build) would be more precise and efficient, and would avoid a duplicate error message if the condition is true. Alternatively, adding a condition like Condition="'$(TargetFramework)' == '$(NetMinimum)'" ensures it runs only once.

Copilot uses AI. Check for mistakes.

</Project>
0 ...rosoft.Data.Sqlite/lib/netstandard2.0/_._ → src/Microsoft.Data.Sqlite/lib/net10.0/_._
View file
Open in desktop
File renamed without changes.
Empty file added src/Microsoft.Data.Sqlite/lib/net472/_._
View file
Open in desktop
Empty file.
Loading