-
Notifications
You must be signed in to change notification settings - Fork 60
Add token caching for AzurePipelinesCredential #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-image-digest-query-slowdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+317
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix extreme slowness in GetAllImageDigestsFromRegistryAsync
Add token caching for AzurePipelinesCredential
Dec 23, 2025
Member
|
@copilot /repo/src/ImageBuilder.Tests/CachingTokenCredentialTests.cs(29,37): error CS0122: 'CachingTokenCredential' is inaccessible due to its protection level |
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Contributor
Author
lbussell
requested changes
Dec 23, 2025
Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetAllImageDigestsFromRegistryAsyncperformance regressionCachingTokenCredentialwrapper that caches tokens and refreshes them when near expirationAzureTokenCredentialProviderto wrapAzurePipelinesCredentialwithCachingTokenCredentialCachingTokenCredentialInternalsVisibleToattribute to allow test project to access internalCachingTokenCredentialclassRoot Cause Analysis
PR #1879 removed the
StaticTokenCredentialclass that was caching tokens. TheAzurePipelinesCredentialwas returned directly, but it does NOT cache tokens internally. Each call toGetTokenfetches a new token from Azure, turning what should be a 1-minute operation into 1+ hours.Solution
Implemented a
CachingTokenCredentialwrapper that:SemaphoreSlimto ensure thread-safe access and prevent concurrent token fetchesOriginal prompt
GetAllImageDigestsFromRegistryAsyncis suddenly extremely slow #1905✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.