Migrate self-hosted grafana to azure managed grafana #6304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/dnceng into haruna/managed-grafana-new
haruna99
changed the title
garath
reviewed
Jan 23, 2026
| dependsOn: ProvisionGrafana | ||
| displayName: 'Setup Grafana API Token' | ||
| variables: | ||
| GrafanaEndpoint: $[ dependencies.ProvisionGrafana.outputs['ExportGrafanaInfo.GrafanaEndpoint'] ] |
Member
There was a problem hiding this comment.
Why use this method with ExportGrafanaInfo instead of parameter variables (like e.g. parameters.AMGGrafanaKeyVault)?
garath
reviewed
Jan 23, 2026
| Write-Host "Granting pipeline service principal Grafana Admin role..." | ||
|
|
||
| $workspaceName = "${{ parameters.AMGGrafanaWorkspaceName }}" | ||
| $rgName = "monitoring-managed" |
Member
There was a problem hiding this comment.
Consider making this a parameter as well. It can have this as the default value. Then all the tweakable variables will be up at the top in the same area.
Member
|
What testing has this seen? |
Contributor
Author
I created a pipeline in the internal repo to test the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.