Add dashboard time format setting with 12/24-hour override#14490
Open
abdallahsellem wants to merge 1 commit intodotnet:mainfrom
Open
Add dashboard time format setting with 12/24-hour override#14490abdallahsellem wants to merge 1 commit intodotnet:mainfrom
abdallahsellem wants to merge 1 commit intodotnet:mainfrom
Conversation
add a Settings dialog option for time format (System, 12-hour, 24-hour) and persist the selection in browser local storage. update BrowserTimeProvider and MainLayout startup flow to restore the saved preference, and apply it through FormatHelpers for time/date-time rendering while preserving culture-specific separators. add localization resources for the new setting and tests covering forced 12/24-hour formatting behavior across cultures.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14490Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14490" |
Contributor
Author
|
@copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a Settings dialog option for time format (System, 12-hour, 24-hour) and persist the selection in browser local storage.
update BrowserTimeProvider and MainLayout startup flow to restore the saved preference, and apply it through FormatHelpers for time/date-time rendering while preserving culture-specific separators.
add localization resources for the new setting and tests covering forced 12/24-hour formatting behavior across cultures.
Fixes #11478
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: