Skip to content

Add AzureServiceTags with common Azure service tags for NSG rules#14452

Draft
Copilot wants to merge 5 commits intorelease/13.2from
copilot/add-common-from-addresses
Draft

Add AzureServiceTags with common Azure service tags for NSG rules#14452
Copilot wants to merge 5 commits intorelease/13.2from
copilot/add-common-from-addresses

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

Description

Adds AzureServiceTags static class providing well-known Azure service tag constants for use as from/to parameters in NSG rule methods and AzureSecurityRule address prefix properties. This gives users discoverability via IntelliSense instead of requiring them to know the magic strings.

Tags included: Internet, VirtualNetwork, AzureLoadBalancer, AzureTrafficManager, Storage, Sql, AzureCosmosDB, AzureKeyVault, EventHub, ServiceBus, AzureContainerRegistry, AppService, AzureActiveDirectory, AzureMonitor, GatewayManager

var subnet = vnet.AddSubnet("web", "10.0.1.0/24")
    .AllowInbound(port: "443", from: AzureServiceTags.AzureLoadBalancer, protocol: SecurityRuleProtocol.Tcp)
    .DenyInbound(from: AzureServiceTags.Internet);

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

karolz-ms and others added 2 commits February 11, 2026 10:53
* Add startup perf collection script

* Analyze trace more efficiently

* Increase pause between iterations

* Fix TraceAnalyzer

* Add startup-perf skill
…tests

Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
Copilot AI changed the title [WIP] Add common from addresses for Azure service tags Add AzureNetworkServiceTags with common Azure service tags for NSG rules Feb 11, 2026
Copilot AI requested a review from eerhardt February 11, 2026 21:28
/// <summary>
/// Represents the Internet address space, including all publicly routable IP addresses.
/// </summary>
public const string Internet = "Internet";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot - change this to use the nameof pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — switched all 15 constants to use nameof in dba2286.

@eerhardt eerhardt changed the base branch from main to release/13.2 February 11, 2026 21:54
Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
/// .DenyInbound(from: AzureNetworkServiceTags.Internet);
/// </code>
/// </example>
public static class AzureNetworkServiceTags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Rename this class and file to just AzureServiceTags. I think "network" is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed class and file to AzureServiceTags in 3a6d50c.

Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
Copilot AI changed the title Add AzureNetworkServiceTags with common Azure service tags for NSG rules Add AzureServiceTags with common Azure service tags for NSG rules Feb 12, 2026
Copilot AI requested a review from eerhardt February 12, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants