-
Notifications
You must be signed in to change notification settings - Fork 565
[Trimming] Put HttpMessageHandler type resolution behind feature switch #10744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
3
commits into
main
Choose a base branch
from
copilot/disable-http-handler-trimming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| --- | ||
| title: .NET for Android error XA1042 | ||
| description: XA1042 error code | ||
| ms.date: 01/29/2026 | ||
| --- | ||
| # .NET for Android error XA1042 | ||
|
|
||
| ## Example messages | ||
|
|
||
| ``` | ||
| The 'AndroidHttpClientHandlerType' property is deprecated and not supported with NativeAOT. The property value 'System.Net.Http.SocketsHttpHandler, System.Net.Http' will be ignored, and the default handler 'Xamarin.Android.Net.AndroidMessageHandler' will be used. Remove the 'AndroidHttpClientHandlerType' property from your project file. To use a custom HTTP handler, pass it to the HttpClient constructor. | ||
| ``` | ||
|
|
||
| ## Issue | ||
|
|
||
| The `AndroidHttpClientHandlerType` MSBuild property is not compatible with NativeAOT because type name resolution at runtime requires reflection, which cannot be safely used with ahead-of-time compilation. | ||
|
|
||
| When targeting NativeAOT, the default `Xamarin.Android.Net.AndroidMessageHandler` handler will always be used regardless of the `AndroidHttpClientHandlerType` property value. | ||
|
|
||
| ## Solution | ||
|
|
||
| Remove the `AndroidHttpClientHandlerType` property from your project file. | ||
|
|
||
| If you need to use a custom HTTP message handler, pass it directly to the `HttpClient` constructor: | ||
|
|
||
| ```csharp | ||
| var handler = new MyCustomHttpHandler(); | ||
| var client = new HttpClient(handler); | ||
| ``` | ||
|
|
||
| This approach is compatible with all .NET for Android runtimes including NativeAOT, CoreCLR, and MonoVM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| title: .NET for Android warning XA1043 | ||
| description: XA1043 warning code | ||
| ms.date: 01/29/2026 | ||
| --- | ||
| # .NET for Android warning XA1043 | ||
|
|
||
| ## Example messages | ||
|
|
||
| ``` | ||
| The 'AndroidHttpClientHandlerType' property is deprecated and will be removed in a future version of .NET for Android. The property value 'System.Net.Http.SocketsHttpHandler, System.Net.Http' will be used, but the recommended approach is to remove the property and pass a custom HTTP handler to the HttpClient constructor if needed. | ||
| ``` | ||
|
|
||
| ## Issue | ||
|
|
||
| The `AndroidHttpClientHandlerType` MSBuild property is deprecated because it relies on runtime type name resolution which is not compatible with trimming and ahead-of-time compilation. While the property still works for MonoVM and CoreCLR runtimes, it will be removed in a future version of .NET for Android. | ||
|
|
||
| ## Solution | ||
|
|
||
| Remove the `AndroidHttpClientHandlerType` property from your project file. | ||
|
|
||
| If you need to use a custom HTTP message handler, pass it directly to the `HttpClient` constructor: | ||
|
|
||
| ```csharp | ||
| var handler = new MyCustomHttpHandler(); | ||
| var client = new HttpClient(handler); | ||
| ``` | ||
|
|
||
| This approach is compatible with all .NET for Android runtimes including NativeAOT, CoreCLR, and MonoVM, and works correctly with trimming and ahead-of-time compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| --- | ||
| title: .NET for Android warning XA1044 | ||
| description: XA1044 warning code | ||
| ms.date: 01/29/2026 | ||
| --- | ||
| # .NET for Android warning XA1044 | ||
|
|
||
| ## Example messages | ||
|
|
||
| ``` | ||
| The 'XA_HTTP_CLIENT_HANDLER_TYPE' environment variable is deprecated and will be removed in a future version of .NET for Android. Remove the environment variable from your @(AndroidEnvironment) files. To use a custom HTTP handler, pass it to the HttpClient constructor. | ||
| ``` | ||
|
|
||
| ## Issue | ||
|
|
||
| The `XA_HTTP_CLIENT_HANDLER_TYPE` environment variable is deprecated because it relies on runtime type name resolution which is not compatible with trimming and ahead-of-time compilation. | ||
|
|
||
| This warning is raised when the build system detects that an `@(AndroidEnvironment)` file contains the `XA_HTTP_CLIENT_HANDLER_TYPE` environment variable. | ||
|
|
||
| ## Solution | ||
|
|
||
| Remove the `XA_HTTP_CLIENT_HANDLER_TYPE` environment variable from your `@(AndroidEnvironment)` files. | ||
|
|
||
| If you need to use a custom HTTP message handler, pass it directly to the `HttpClient` constructor: | ||
|
|
||
| ```csharp | ||
| var handler = new MyCustomHttpHandler(); | ||
| var client = new HttpClient(handler); | ||
| ``` | ||
|
|
||
| This approach is compatible with all .NET for Android runtimes including NativeAOT, CoreCLR, and MonoVM, and works correctly with trimming and ahead-of-time compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonrozsival can we use the existing feature switch, and we don't need a new one?
We'd duplicate it in this file like we did
StartupHookProvider.IsSupported.