-
Notifications
You must be signed in to change notification settings - Fork 565
Fix net.android.init.gradle.kts for Gradle 9.x compatibility #10738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-kotlin-dsl-incompatibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+112
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix generated net.android.init.gradle.kts for Gradle 9.x
Fix net.android.init.gradle.kts for Gradle 9.x compatibility
Jan 28, 2026
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/CopyResourceTests.cs
Outdated
Show resolved
Hide resolved
…test Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
…nit scripts Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
…new public property Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.android.init.gradle.ktsresource file to handle nullable case using Kotlin's?.let {}patternAgpVersionandGradleVersionproperties toAndroidGradleProjectfor version configurationBindLibraryWithMultipleGradleVersionsthat tests binding projects with multiple AGP/Gradle version combinations$(_AGPInitScriptPath)property as escape hatch for custom init scriptsSummary
This PR fixes the generated
net.android.init.gradle.ktsKotlin DSL script to be compatible with Gradle 9.x by using Kotlin's null-safe?.let {}pattern instead of explicitly checkingcontainsKeyand then accessing the potentially nullable value.Escape Hatch Property
Users can now provide their own custom
init.gradle.ktsfile by overriding the existing$(_AGPInitScriptPath)property:When set to a path outside the intermediate output directory, the build will skip copying the built-in resource and use the user's file directly.
Integration Tests
The integration test verifies compatibility across multiple AGP/Gradle versions:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.