Skip to content

[tests] add test for package-less [Register("CustomView"] #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 7 commits into from
Jan 27, 2026
Merged

[tests] add test for package-less [Register("CustomView"] #10717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ca9c909
Initial plan
Copilot Jan 23, 2026
264f73e
Add proper MSBuild error (XA4238) for JCW XML import failures
Copilot Jan 23, 2026
25c088a
Add test for XA4238 error when Register attribute has no package
Copilot Jan 23, 2026
4e03714
Bump java.interop
jonathanpeppers Jan 26, 2026
64f84fe
Revert "Add proper MSBuild error (XA4238) for JCW XML import failures"
jonathanpeppers Jan 26, 2026
cbe8edc
Rework test
jonathanpeppers Jan 26, 2026
cdccb7a
Merge branch 'main' into copilot/fix-register-attribute-build
jonathanpeppers Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
<LibUnwindSourceFullPath>$([System.IO.Path]::GetFullPath ('$(LibUnwindSourceDirectory)'))</LibUnwindSourceFullPath>
<LibUnwindGeneratedHeadersFullPath>$([System.IO.Path]::GetFullPath ('$(LibUnwindGeneratedHeadersDirectory)'))</LibUnwindGeneratedHeadersFullPath>
<LZ4SourceFullPath>$([System.IO.Path]::GetFullPath ('$(LZ4SourceDirectory)'))</LZ4SourceFullPath>
<JavaInteropTargetFrameworkVersion>net9.0</JavaInteropTargetFrameworkVersion>
<JavaInteropTargetFrameworkVersion>net10.0</JavaInteropTargetFrameworkVersion>
</PropertyGroup>
<PropertyGroup>
<AdbToolPath Condition=" '$(AdbToolPath)' == '' ">$(AndroidSdkFullPath)\platform-tools\</AdbToolPath>
Expand Down
2 changes: 1 addition & 1 deletion external/Java.Interop
Open in desktop
Submodule Java.Interop updated 6 files
+1 −1 Directory.Build.props
+2 −2 build-tools/automation/azure-pipelines.yaml
+36 −0 src/Java.Interop.Tools.JavaCallableWrappers/Java.Interop.Tools.JavaCallableWrappers.Adapters/XmlImporter.cs
+15 −13 src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs
+1 −0 src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs
+144 −0 ...s/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/XmlImporterTests.cs
22 changes: 22 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2212,5 +2212,27 @@ public void SystemIOHashing ([Values] AndroidRuntime runtime)
using var builder = CreateApkBuilder ();
Assert.IsTrue (builder.Build (proj), "build should have succeeded.");
}

[Test]
public void CustomView_NoPackage ()
{
var proj = new XamarinAndroidApplicationProject ();
proj.Sources.Add (new BuildItem ("Compile", "CustomView.cs") { TextContent = () => @"
using Android.Content;
using Android.Runtime;
using Android.Views;

namespace UnnamedProject
{
// Register attribute without package prefix should cause XA4238
[Register(""CustomView"")]
public class CustomView : View
{
public CustomView (Context context) : base (context) { }
}
}" });
using var builder = CreateApkBuilder ();
Assert.IsTrue (builder.Build (proj), "Build should have succeeded.");
}
}
}