-
Notifications
You must be signed in to change notification settings - Fork 565
[xabt] use a response file when calling java r8.jar
#10716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… length limits Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
…te argument Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Fixed in c387499. The issue was that I was adding quotes around paths with spaces in the response file, but R8/D8's response file parser treats each line as a complete argument - no quoting is needed. Removed the quoting logic from |
java r8.jar
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already surprisingly decent, but I reran some test lanes to get it completely green.
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot you completely missed adding the same treatment to the <R8/> task that extends D8!
This task should be using the same response file for all arguments -- otherwise, it will just hit the limit eventually, too!
…s to response file Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Fixed in 75f4235. Modified R8.cs to override |
…nd line Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
@argfilesyntax)IsNullOrEmpty()extension method instead ofis { Length: > 0 }pattern in D8.cs--pg-conf,--main-dex-list, etc.) to response file in R8.cs-Xmx,-classpath, main class)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.