Skip to content

Improve MDNode operands implementation #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Sep 28, 2025
Merged

Improve MDNode operands implementation #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sources/LLVMSharp.Interop/Extensions/LLVMValueRef.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ public readonly LLVMLinkage Linkage
}
}

public readonly uint MDNodeOperandsCount => (Kind == LLVMValueKind.LLVMMetadataAsValueValueKind) ? LLVM.GetMDNodeNumOperands(this) : default;
public readonly uint MDNodeOperandsCount => (IsAMDNode == null) ? LLVM.GetMDNodeNumOperands(this) : default;

public readonly string Name
{
Expand Down Expand Up @@ -895,19 +895,20 @@ public readonly void GetBasicBlocks(Span<LLVMBasicBlockRef> destination)

public readonly LLVMValueRef[] GetMDNodeOperands()
{
if (Kind != LLVMValueKind.LLVMMetadataAsValueValueKind)
uint count = MDNodeOperandsCount;
if (count == 0)
{
return [];
}

var destination = new LLVMValueRef[MDNodeOperandsCount];
var destination = new LLVMValueRef[count];
GetMDNodeOperands(destination);
return destination;
}

public readonly void GetMDNodeOperands(Span<LLVMValueRef> destination)
{
if (Kind != LLVMValueKind.LLVMMetadataAsValueValueKind)
if (IsAMDNode == null)
{
return;
}
Expand Down
Loading