Change BillingAddress to allow NULL values#5247
Merged
roji merged 2 commits intodotnet:mainfrom Jan 18, 2026
Merged
Conversation
"NOT NULL NULL" is not valid T-SQL. Given it refers to the previous type, allowing this column to be nullable seems to be what was intended.
roji
approved these changes
Jan 18, 2026
Member
roji
left a comment
There was a problem hiding this comment.
Thanks for spotting the error, but I don't see any reason for this to be nullable, given that ShippingAddress just above is non-nullable and they configured exactly the same (plus the section just above - for table splitting - shows two non-nullable properties.
Contributor
Author
|
But it isn't! If you refer to the most recent definition above it is defined like this: public class Customer
{
...
public Address ShippingAddress { get; set; }
public Address? BillingAddress { get; set; }
} |
Member
|
Oops, you're right - sorry about that. Submitted #5250 to correct it. |
roji
added a commit
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"NOT NULL NULL" is not valid T-SQL. Given it refers to the previous type, allowing this column to be nullable seems to be what was intended.