Skip to content

Conversation

@walterlv
Copy link
Member

@walterlv walterlv commented Aug 29, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the minimum .NET version requirement for DynamicallyAccessed attributes from .NET 6.0 to .NET 5.0, aligning with the official Microsoft documentation. The changes update conditional compilation directives and comments to reflect the accurate version availability.

  • Updated conditional compilation from NET6_0_OR_GREATER to NET5_0_OR_GREATER for DynamicallyAccessed polyfill
  • Corrected documentation comments to indicate .NET 5.0 as the starting version
  • Added .NET 9.0 to the test framework targets and included analyzer debugging configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
DynamicallyAccessed.g.cs Updated conditional compilation directive to target .NET 5.0+ instead of .NET 6.0+
FeatureGenerator.cs Corrected comment to reflect .NET 5.0 as the starting version for DynamicallyAccessed
DotNetCampus.LatestCSharpFeatures.Tests.csproj Added .NET 9.0 to target frameworks list
launchSettings.json Added new analyzer debugging configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lindexi lindexi merged commit fba17bc into main Aug 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants