Skip to content

Conversation

@dotMorten
Copy link
Owner

No description provided.

@dotMorten dotMorten self-assigned this Oct 12, 2025
@dotMorten dotMorten requested a review from Copilot October 12, 2025 06:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the tray icon functionality in WinUIEx by introducing a new dedicated TrayIcon class to replace the previous integrated approach within WindowManager. The refactoring improves maintainability and provides a more focused API for tray icon management.

  • Replaces unified TrayIconInvoked event with separate LeftClick and RightClick events for cleaner event handling
  • Introduces new TrayIcon class that encapsulates all tray icon functionality and flyout management
  • Deprecates legacy Icon-related APIs in favor of the newer AppWindow.SetTaskbarIcon approach

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/WinUIExSample/MainWindow.xaml.cs Updates sample to use new separate click events instead of unified tray icon event
src/WinUIEx/WindowManager.cs Removes legacy tray icon implementation and struct definitions
src/WinUIEx/WindowManager.TrayIcon.cs Replaces complex tray icon logic with delegation to new TrayIcon class
src/WinUIEx/WindowExtensions.cs Marks SetTaskBarIcon extension method as obsolete
src/WinUIEx/WindowEx.cs Marks TaskBarIcon property as obsolete
src/WinUIEx/TrayIcon.cs Adds new comprehensive TrayIcon class with full functionality
src/WinUIEx/Interop.cs Moves reusable interop structures and adds Shell_NotifyIconGetRect import
src/WinUIEx/Icon.cs Marks entire Icon class as obsolete
src/WinUIEx/HwndExtensions.cs Marks SetTaskBarIcon method as obsolete
Comments suppressed due to low confidence (1)

src/WinUIEx/TrayIcon.cs:1

  • The method parameter tooltip is checked but the instance field _tooltip is used in the loop. This causes the tooltip parameter to be ignored when it's provided.
using Microsoft.UI;

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dotMorten dotMorten requested a review from Copilot October 12, 2025 20:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dotMorten dotMorten requested a review from Copilot October 13, 2025 01:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dotMorten dotMorten requested a review from Copilot October 13, 2025 01:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dotMorten dotMorten requested a review from Copilot October 13, 2025 01:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dotMorten dotMorten requested a review from Copilot October 13, 2025 01:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dotMorten dotMorten merged commit a4f5aec into main Oct 13, 2025
1 check passed
@dotMorten dotMorten deleted the trayicon branch October 13, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants