Add query a dataset to client #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 5, 2020
| else: | ||
| self.logger.debug("Error querying " + obj_desc + ": " | ||
| + self.transport.dump_response(response)) | ||
| raise Exception("Error querying " + obj_desc + ": " + response.text) |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
Author
There was a problem hiding this comment.
Made the line adjustment, is it possible to get this PR merged now?
Adjusted "long line" for the stickler!
Author
|
Made the line adjustment, is it possible to get this PR merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the features on the API that I really wanted to use and I know others will is the ability to query a dataset. I have added this to the client and did a basic test. Of course, feel free to check my work. Also, I did not add it to examples.