Creates delegation of DCIntrospect and update the demo. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows user to extends useful functionality, like keyboard inputs, for their own use cases. As the project is iOS 4 compatible, delegate property is set as assign, which requires the user to nil the delegate upon deallocation. It would be better if we can make use of the weak property attribute instead which release the user the responsibility of setting the delegate to nil.
|
Hi, thanks for the pull request though unfortunately it looks like DCIntrospect is no longer maintained. Good news though, myself and @Logicreative have decided to revive DCIntrospect, and created a fork at https://github.com/logicreative/DCIntrospect-ARC to hopefully merge all pull requests and forks back into a single repo. If you don't mind sending your pull request to the DCIntrospect-ARC repo, we'll try and merge it as quickly as possible. We're also going to be more active with the CocoaPods package manager, so we'll update the latest CocoaPod's podspect once all changes have been merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to extends useful functionality, like keyboard inputs, for their own use cases.
As the project is iOS 4 compatible, delegate property is set as assign, which requires the user to nil the delegate upon deallocation.
It would be better if we can make use of the weak property attribute instead which release the user the responsibility of setting the delegate to nil.