Migrating from Restify 4.x to Restify 5.x. Closes #47#48
Open
mariopeixoto wants to merge 2 commits intodomenic:masterfrom
Open
Migrating from Restify 4.x to Restify 5.x. Closes #47#48mariopeixoto wants to merge 2 commits intodomenic:masterfrom
mariopeixoto wants to merge 2 commits intodomenic:masterfrom
Conversation
|
@domenic any word on reviewing at the PR? :) |
|
Any update on whether this can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #47.
Please review and let me know if this works for you. Since Restify 5.x removed the
restify.errorsproperty, I had to use therestify-errorspackage.The most important change is that restify-errors don't allow the customization of the
body, but it does allow the creation of new errors using themakeConstructorfunction. So the JSON output will change a little bit from { error: ..., errorDescription: ...} to { code: ..., message: ... }. Does that comply with the specification?