Fix check_domains return type annotation #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_domainsfunction was annotated to returnMXHost, but actually returns a dict with domain check results (single domain) or a list of such dicts (multiple domains).Changes
Added
DomainCheckResultTypedDict defining the actual return structure with fields:domain,base_domain,dnssec,soa,ns,mx,spf,dmarc,smtp_tls_reporting,mta_sts, and optionallybimiUpdated return type from
-> MXHostto-> Union[DomainCheckResult, list[DomainCheckResult]]Updated docstring to document all returned fields instead of the incomplete list
Imported result types from submodules to properly type the
DomainCheckResultfieldsExample
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
vmc.digicert.com/usr/bin/python3 python3 tests.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.