Skip to content

Workaround for RelaxedJS '--build-once' not working#15

Open
nbanyan wants to merge 2 commits intodomWalters:developfrom
nbanyan:release-v0.9.4
Open

Workaround for RelaxedJS '--build-once' not working#15
nbanyan wants to merge 2 commits intodomWalters:developfrom
nbanyan:release-v0.9.4

Conversation

@nbanyan
Copy link
Copy Markdown

@nbanyan nbanyan commented Jul 8, 2024

Kill the RelaxedJS process when it becomes idle to allow PDF build process to continue.

@domWalters domWalters changed the base branch from release-v0.9.4 to develop December 16, 2024 17:56
@domWalters
Copy link
Copy Markdown
Owner

Hi,

Apologies, I seem to have not been getting notifications for this repo for months and I've only just realised.

Can you explain why the image style attribute fix is needed? Happy with the proc.kill() part.

@nbanyan
Copy link
Copy Markdown
Author

nbanyan commented Jan 23, 2025

It's been a while, but I remember that method completely replacing the style attribute instead of adding to the existing attribute. I think it was something about getattr being deprecated and img.get is the current way of getting an element's attribute.

@domWalters domWalters self-assigned this Mar 15, 2025
@domWalters domWalters added the bug Something isn't working label Mar 15, 2025
@domWalters domWalters added this to the v0.11.0 milestone Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants