-
Notifications
You must be signed in to change notification settings - Fork 0
๐ :: [#728] - CD ์ ์ฉ #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughGitHub Actions CD ์ํฌํ๋ก์ฐ, Lambda ๋ฐฐํฌ ํจํค์ง ๋น๋ ์คํฌ๋ฆฝํธ, S3 ๋ฒํท ์ด๋ฒคํธ ๊ธฐ๋ฐ Lambda ์คํ์ ์ํ Terraform ์ธํ๋ผ ์ฝ๋(IAM, SSM, Lambda, ์๋ฆผ ์ค์ ํฌํจ)๋ฅผ ์ถ๊ฐํฉ๋๋ค. Changes
Sequence Diagram(s)sequenceDiagram
participant S3 as S3 Bucket
participant Lambda as Lambda Function
participant SSM as SSM Parameter Store
participant SSH as Remote Host
S3->>Lambda: ObjectCreated:Put Event<br/>(build/* prefix)
Lambda->>SSM: Get SSH Private Key<br/>(SSM_PARAM_NAME)
SSM-->>Lambda: Private Key Value
Lambda->>SSH: Connect via SSH<br/>(RSAKey, 10s timeout)
SSH-->>Lambda: Connection Established
Lambda->>SSH: Execute Command<br/>bash /home/{user}/deploy.sh<br/>{bucket} {key}
SSH-->>Lambda: stdout + stderr
Lambda-->>S3: Return Result<br/>(stdout/stderr dict)
Estimated code review effort๐ฏ 3 (Moderate) | โฑ๏ธ ~25 minutes ์ฌ๋ฌ ์ด์ง์ ์ธ ๊ธฐ์ (GitHub Actions, Bash, Terraform, Python/boto3/paramiko)์ด ํฌํจ๋์ด ์๊ณ AWS ์๋น์ค ๊ฐ ์ฐ๋ ๋ก์ง์ด ์์ด ๊ฐ ํ์ผ๋ณ๋ก ๋ ๋ฆฝ์ ์ธ ๊ฒํ ๊ฐ ํ์ํฉ๋๋ค. ๋ค๋ง ๊ฐ ํ์ผ์ ๋ณ๊ฒฝ ๋ด์ฉ ์์ฒด๋ ์๋์ ์ผ๋ก ๋ช ํํ ๊ตฌ์กฐ๋ฅผ ๊ฐ์ง๊ณ ์์ต๋๋ค. Possibly related issues
Poem
โจ Finishing touches
๐งช Generate unit tests (beta)
๐ Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ๐ Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
๊ฐ์
์์ ๋ด์ฉ
์ฒดํฌ๋ฆฌ์คํธ
Summary by CodeRabbit
๋ฆด๋ฆฌ์ค ๋ ธํธ
์๋ก์ด ๊ธฐ๋ฅ
์ธํ๋ผ
์ค์