This repository was archived by the owner on Jun 6, 2024. It is now read-only.
fix new Function(<string>) allowing for arbitrary code execution
#149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
reviewed
Mar 9, 2020
| const bindings = { EvalError: EvalError } | ||
| expect(() => { new Cloudworker(`new Function('true')`, { bindings }) }).toThrow(new EvalError('Code generation from strings disallowed for this context')) // eslint-disable-line no-new | ||
| }) | ||
| }) |
There was a problem hiding this comment.
could you please add a test for disallowing Function.constructor("console.log(1)")() and similarly ({}).constructor.constructor("console.log(1)")()?
Also note that code generation applies to wasm as well:
const arr = [];
new WebAssembly.Module(arr)should be disallowed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pay attention to the security note — I'm really not sure if there's a way to hack around this or not. But this at least makes us consistent with CF workers in the common case.
fixes #146