Skip to content

Conversation

@hyblocker
Copy link
Contributor

WIP work on all rumble classes, currently working on TMovieRumble and then will finish with RumbleMgr.

@decomp-dev
Copy link

decomp-dev bot commented Oct 12, 2025

Report for GMSJ01 (0d49c4b - 0d60d64)

📈 Matched code: 25.03% (+0.06%, +2196 bytes)
📈 Linked code: 13.21% (+0.01%, +536 bytes)

✅ 21 new matches
Unit Function Bytes Before After
mario/MarioUtil/RumbleMgr RumbleControllerMgr::stop(int) +316 0.00% 100.00%
mario/MarioUtil/ToolData Koga::ToolData::GetValue(int, const char*, const char*&) const +204 0.00% 100.00%
mario/MarioUtil/ToolData Koga::ToolData::GetValue(int, const char*, long&) const +204 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleControllerMgr::updateMotorCount() +128 0.00% 100.00%
mario/GC2D/MovieRumble TMovieRumble::perform(unsigned long, JDrama::TGraphics*) +128 0.00% 100.00%
mario/GC2D/MovieRumble TMovieRumble::TMovieRumble(const TTHPRender*) +124 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::startPause() +116 0.00% 100.00%
mario/GC2D/MovieRumble TMovieRumble::~TMovieRumble() +116 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::start(int, Vec*) +92 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::start(int, float*) +92 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleControllerMgr::start(int, int, Vec*) +88 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleControllerMgr::start(int, int, float*) +88 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::stop(int) +84 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::start(int, int, Vec*) +84 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::start(int, int, float*) +84 0.00% 100.00%
mario/MarioUtil/ToolData Koga::ToolData::~ToolData() +76 0.00% 100.00%
mario/MarioUtil/RumbleMgr JGeometry::TUtil<float>::sqrt(float) +56 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleChannelMgr::RumbleChannelMgr() +44 0.00% 100.00%
mario/MarioUtil/ToolData Koga::ToolData::Attach(const void*) +28 0.00% 100.00%
mario/MarioUtil/ToolData Koga::ToolData::ToolData() +24 0.00% 100.00%
mario/MarioUtil/RumbleMgr RumbleMgr::finishPause() +20 0.00% 100.00%
📈 11 improvements in unmatched functions
Unit Function Bytes Before After
mario/GC2D/MovieRumble TMovieRumble::init(const char*) +288 0.00% 81.82%
mario/GC2D/MovieRumble TMovieRumble::checkRumbleOff() +172 0.00% 64.18%
mario/MarioUtil/RumbleMgr RumbleChannelMgr::update() +167 0.00% 24.42%
mario/MarioUtil/RumbleMgr RumbleControllerMgr::update() +154 0.00% 67.80%
mario/MarioUtil/RumbleMgr RumbleMgr::update() +126 0.00% 17.45%
mario/MarioUtil/RumbleMgr RumbleMgr::reset() +115 0.00% 23.20%
mario/MarioUtil/RumbleMgr RumbleMgr::RumbleMgr(bool, bool, bool, bool) +112 0.00% 35.90%
mario/MarioUtil/RumbleMgr RumbleMgr::init() +108 0.00% 20.30%
mario/MarioUtil/RumbleMgr RumbleControllerMgr::reset() +107 0.00% 27.55%
mario/MarioUtil/RumbleMgr RumbleMgr::stop() +88 0.00% 26.51%
mario/MarioUtil/RumbleMgr RumbleMgr::setActive(bool) +75 0.00% 42.22%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant