Skip to content

link st_config.rel and st_final.rel#68

Merged
mparisi20 merged 1 commit intodoldecomp:mainfrom
MarioLover63:stage-modules
Sep 3, 2025
Merged

link st_config.rel and st_final.rel#68
mparisi20 merged 1 commit intodoldecomp:mainfrom
MarioLover63:stage-modules

Conversation

@MarioLover63
Copy link
Contributor

No description provided.

@decomp-dev
Copy link

decomp-dev bot commented Sep 2, 2025

Report for RSBE01_02 (eb0cfa6 - 707c9df)

📈 Matched code: 0.92% (+0.03%, +4000 bytes)
📈 Linked code: 0.79% (+0.03%, +4000 bytes)

✅ 118 new matches
Unit Function Bytes Before After
st_final/mo_stage/st_final/st_final stFinal::createObj() +592 0.00% 100.00%
st_final/mo_stage/st_final/gr_final grFinal::updateEff() +516 0.00% 100.00%
st_config/mo_stage/st_config/st_config stConfig::createObj() +344 0.00% 100.00%
st_final/mo_stage/st_final/gr_final grFinal::create(int, const char*, const char*) +224 0.00% 100.00%
st_config/mo_stage/st_config/gr_config grConfig::create(int, const char*, const char*) +196 0.00% 100.00%
st_config/mo_stage/st_config/st_config stClassInfoImpl<38, stConfig>::~stClassInfoImpl() +116 0.00% 100.00%
st_final/mo_stage/st_final/st_final stClassInfoImpl<2, stFinal>::~stClassInfoImpl() +116 0.00% 100.00%
st_config/mo_stage/st_config/st_config stConfig::~stConfig() +108 0.00% 100.00%
st_final/mo_stage/st_final/st_final stFinal::~stFinal() +108 0.00% 100.00%
st_config/mo_stage/st_config/st_config __sinit_\st_config_cpp +100 0.00% 100.00%
st_final/mo_stage/st_final/st_final __sinit_\st_final_cpp +100 0.00% 100.00%
st_config/mo_stage/st_config/st_config stConfig::create() +92 0.00% 100.00%
st_config/mo_stage/st_config/st_config stClassInfoImpl<38, stConfig>::create() +92 0.00% 100.00%
st_final/mo_stage/st_final/st_final stFinal::create() +92 0.00% 100.00%
st_final/mo_stage/st_final/st_final stClassInfoImpl<2, stFinal>::create() +92 0.00% 100.00%
st_config/mo_stage/st_config/gr_config grConfig::~grConfig() +88 0.00% 100.00%
st_final/mo_stage/st_final/gr_final grFinal::~grFinal() +88 0.00% 100.00%
st_config/mo_stage/st_config/st_config Stage::getScrollDir(Vec3f*) +28 0.00% 100.00%
st_config/mo_stage/st_config/gr_config Ground::getModelCount() +28 0.00% 100.00%
st_final/mo_stage/st_final/st_final Stage::getScrollDir(Vec3f*) +28 0.00% 100.00%
st_final/mo_stage/st_final/gr_final Ground::getModelCount() +28 0.00% 100.00%
st_config/mo_stage/st_config/st_config Stage::getBgmChangeID(unsigned long*, float*) +20 0.00% 100.00%
st_final/mo_stage/st_final/st_final Stage::getBgmChangeID(unsigned long*, float*) +20 0.00% 100.00%
st_config/mo_stage/st_config/st_config Stage::setBgmChange(float, bool, unsigned long) +16 0.00% 100.00%
st_config/mo_stage/st_config/gr_config Ground::disableCalcCollision() +16 0.00% 100.00%
st_config/mo_stage/st_config/gr_config Ground::enableCalcCollision() +16 0.00% 100.00%
st_final/mo_stage/st_final/st_final Stage::setBgmChange(float, bool, unsigned long) +16 0.00% 100.00%
st_final/mo_stage/st_final/gr_final grFinal::update(float) +16 0.00% 100.00%
st_final/mo_stage/st_final/gr_final Ground::disableCalcCollision() +16 0.00% 100.00%
st_final/mo_stage/st_final/gr_final Ground::enableCalcCollision() +16 0.00% 100.00%

...and 88 more new matches

@mparisi20
Copy link
Collaborator

There's some discrepancy between the matched and linked code; A function is in a "Matching" file but is apparently only 50% matching.

@MarioLover63
Copy link
Contributor Author

the problem was in the symbols.txt file, accidentally had getGimmickData twice

@mparisi20 mparisi20 merged commit ee68c7b into doldecomp:main Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants