Remove color if not tty #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoivo
force-pushed
the
st-remove-color-if-not-tty
branch
from
714c06e to
cbbb5f9
Compare
odinhb
suggested changes
Jun 7, 2024
| ## [Unreleased] | ||
|
|
||
| - Add option to disable color with environment variable "NO_COLOR" | ||
| - Default coloring to true if $stdout is terminal |
Contributor
There was a problem hiding this comment.
documenting this in the README too would be nice
|
|
||
| ## [Unreleased] | ||
|
|
||
| - Add option to disable color with environment variable "NO_COLOR" |
Contributor
There was a problem hiding this comment.
this line should be under a ### Added heading while the next should be under ### Changed
review the keep a changelog link at the top
| def self.default_configuration | ||
| config = Config.new(colorize: true) | ||
|
|
||
| if !ENV["NO_COLOR"].nil? && !ENV["NO_COLOR"].empty? |
Contributor
There was a problem hiding this comment.
consider a spec for this (in specdiff_spec.rb)
it might be unexpected that NO_COLOR=0 sets color to true
Collaborator
Author
|
With this patch I think CI with stop having colors Maybe we should have some env to force color too?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.