Skip to content

Fix account not selected on bank.tabjournal and date warning on journal.edit #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mladjo2505 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix account not selected on bank.tabjournal and date warning on journal.edit #485

mladjo2505 wants to merge 1 commit into from

Conversation

@mladjo2505
Copy link
Contributor

@mladjo2505 mladjo2505 commented Apr 24, 2017

Closes #470

@mladjo2505 mladjo2505 self-assigned this Apr 24, 2017
@mladjo2505 mladjo2505 requested a review from sls-lnluksa April 24, 2017 13:30
@mladjo2505
Copy link
Contributor Author

mladjo2505 commented May 10, 2017 •
edited
Loading

  • Talk with @hildegunn95 about how to save dates and how to show warnings on journal edit page

@mladjo2505
Copy link
Contributor Author

mladjo2505 commented May 12, 2017

When the journal's date is invalid(ex. 2016-06-31 or 2017-45-56) do not allow any save actions and alert with the message 'Journal date is invalid.'('Bilagsdato er ikke gyldig').
Also if the date is not in the journal's selected period just add a warning label next to the period dropdown, something like 'Journal period is not the same as journal date.'('Perioden er ikke lik bilagsdato.')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sls-lnluksa sls-lnluksa Awaiting requested review from sls-lnluksa

Assignees

@mladjo2505 mladjo2505

Labels

Back to rework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mladjo2505