-
Notifications
You must be signed in to change notification settings - Fork 0
Implement car registrations #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| $car_exists_query = "SELECT * FROM car WHERE CarID = ".$args['value']; | ||
| $rs = $_lib['db']->db_query($car_exists_query); | ||
| $car_exists = $_lib['db']->db_fetch_object($rs) != null; | ||
| if(!$car_exists) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this out of this if
| else | ||
| $print .= "<option value=\"$_row->CarID\">" . $inaktive . substr($_row->CarID." - ".$name, 0, $num_letters) . "\n"; | ||
| if(!$args['car_registration_menu']) { | ||
| if($_row->CarID == $args[value]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract from ifs
| } | ||
| } | ||
|
|
||
| // trim car codes (registration number) and save them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this to top
| $CarCode = $_SESSION['oauth_car_code']; | ||
| $CarID = $_SESSION['oauth_car_id']; | ||
| unset($_SESSION['oauth_car_code']); | ||
| $CarCodes = $_SESSION['oauth_car_codes']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this part of code with @mladjo2505
Closes FB#801