Skip to content

Conversation

@Baxxx
Copy link
Contributor

@Baxxx Baxxx commented Apr 5, 2017

Closes FB#801

@Baxxx Baxxx requested a review from sls-lnluksa April 5, 2017 12:55
@Baxxx Baxxx self-assigned this Apr 5, 2017
$car_exists_query = "SELECT * FROM car WHERE CarID = ".$args['value'];
$rs = $_lib['db']->db_query($car_exists_query);
$car_exists = $_lib['db']->db_fetch_object($rs) != null;
if(!$car_exists) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this out of this if

else
$print .= "<option value=\"$_row->CarID\">" . $inaktive . substr($_row->CarID." - ".$name, 0, $num_letters) . "\n";
if(!$args['car_registration_menu']) {
if($_row->CarID == $args[value])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract from ifs

}
}

// trim car codes (registration number) and save them
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this to top

$CarCode = $_SESSION['oauth_car_code'];
$CarID = $_SESSION['oauth_car_id'];
unset($_SESSION['oauth_car_code']);
$CarCodes = $_SESSION['oauth_car_codes'];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this part of code with @mladjo2505

@sls-lnluksa sls-lnluksa requested a review from stoivo April 12, 2017 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants