-
Notifications
You must be signed in to change notification settings - Fork 12
Add scripts to deploy multi-cloud telemetry #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| unzip /tmp/v${DocumentDB_VERSION}.zip -d /home/documentdb/code && \ | ||
| rm /tmp/v${DocumentDB_VERSION}.zip | ||
|
|
||
| #RUN wget -P /tmp https://github.com/documentdb/documentdb/archive/refs/tags/v${DocumentDB_VERSION}.zip && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove commented code? We have version history so no need to retain
|
|
||
| WORKDIR /home/documentdb/gateway/scripts | ||
| #ENTRYPOINT ["/bin/bash", "-c", "/home/documentdb/gateway/scripts/emulator_entrypoint.sh \"$@\"", "--"] | ||
| ENTRYPOINT ["/bin/bash", "-c", "/home/documentdb/gateway/scripts/emulator_entrypoint.sh \"$@\"", "--"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we had some issues and we commented it out. Now adding back. Do you remember why? Also, I prefer to make this type of changes in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember an entrypoint issue, myself. We used this dockerfile to build and run a gateway image for testing and it seemed to work fine
move scripts to proper folder Add telemetry scripts try new docker image adjust dockerfiles change to local build dockerfile Add telemetry deployment option add final demo touches
move to new folder and add docs Signed-off-by: Alexander Laye <alaye@microsoft.com> adjust scripts fix deploy location add backup resource delete commented code revert to pulling the archive instead of using local docdb
0007e8e to
098fc67
Compare
No description provided.