fix: pin pydantic to <2.12.5 due to string constraints parameter change#32
Open
ajuijas wants to merge 1 commit intodocling-project:mainfrom
Open
fix: pin pydantic to <2.12.5 due to string constraints parameter change#32ajuijas wants to merge 1 commit intodocling-project:mainfrom
ajuijas wants to merge 1 commit intodocling-project:mainfrom
Conversation
Contributor
|
✅ DCO Check Passed Thanks @ajuijas, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: ajuijas <ijas.ahmd.ap@gmail.com>
ajuijas
force-pushed
the
fix/pydantic-string-constraints-issue-31
branch
from
e4bb2dd to
037c86b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Description:
This PR pins
pydanticto<2.12.5to resolve an import error withStringConstraints()that occurs when using newer versions of Pydantic with the currently stabledocling-core.The issue stems from a breaking change in Pydantic 2.12.5 where
StringConstraints()no longer accepts positional arguments, which breaksdocling_core/search/package.py. By capping the pydantic version,langchain-doclingusers will avoid this error untildocling-coreis bumped.