feat: update OmniDocBench with Parquet support and add test#198
Open
feat: update OmniDocBench with Parquet support and add test#198
Conversation
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @samiuc, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
Contributor
Author
|
@cau-git can you please review the PR when you have sometime? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OmniDocBench dataset contains ~2700 individual files. When downloading via the raw mode (file-by-file), each file triggers a separate request to HuggingFace's API. In parallel test environments, this quickly hits HuggingFace's rate limit of 1000 requests per 5 minutes, causing test failures.
So in the PR, I have:
use_parquetparameter to OmniDocBenchDatasetBuilder that enables downloading pre-converted Parquet shards instead of individual files_iterate_parquet()method that usesload_dataset()to stream data from Parquet files, reducing the number of API requestsThe Parquet version of OmniDocBench is available at: https://huggingface.co/datasets/samiuc/OmniDocBench-parquet
Question: can we move it to
doclingrepo on HF?