Skip to content

fix(Doclang): fix serialization order in text items #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vagenas wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Draft

fix(Doclang): fix serialization order in text items #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docling_core/experimental/doclang.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,11 @@ def _serialize_single_item(

parts: list[str] = []

if item.meta:
meta_res = doc_serializer.serialize_meta(item=item, **kwargs)
if meta_res.text:
parts.append(meta_res.text)

if params.add_location:
# Use Doclang `<location>` tokens instead of `<loc_.../>`
loc = _create_location_tokens_for_item(item=item, doc=doc, xres=params.xsize, yres=params.ysize)
Expand All @@ -1524,11 +1529,6 @@ def _serialize_single_item(
if selected_token:
parts.append(selected_token)

if item.meta:
meta_res = doc_serializer.serialize_meta(item=item, **kwargs)
if meta_res.text:
parts.append(meta_res.text)

if (
(isinstance(item, CodeItem) and ContentType.TEXT_CODE in params.content_types)
or (isinstance(item, FormulaItem) and ContentType.TEXT_FORMULA in params.content_types)
Expand Down
8 changes: 4 additions & 4 deletions test/data/doc/dummy_doc_with_meta.gt.dclg.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<doclang version="1.0.0">
<title>
<location value="43"/>
<location value="26"/>
<location value="415"/>
<location value="47"/>
<meta>
<summary>This is a title.</summary>
<my_corp__foo>More stuff here.</my_corp__foo>
</meta>
<location value="43"/>
<location value="26"/>
<location value="415"/>
<location value="47"/>
DocLayNet: A Large Human-Annotated Dataset for Document-Layout Analysis
</title>
<floating_group class="picture">
Expand Down
Loading