feat(markdown): add footnote serialization support#569
Open
ShrillHarrier wants to merge 2 commits intodocling-project:mainfrom
Open
feat(markdown): add footnote serialization support#569ShrillHarrier wants to merge 2 commits intodocling-project:mainfrom
ShrillHarrier wants to merge 2 commits intodocling-project:mainfrom
Conversation
Contributor
|
✅ DCO Check Passed Thanks @ShrillHarrier, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, Matthew Panizza <Matthew.Panizza@ibm.com>, hereby add my Signed-off-by to this commit: 73a9a40 Signed-off-by: Matthew Panizza <Matthew.Panizza@ibm.com>
|
Related Documentation 1 document(s) may need updating based on files changed in this PR: Docling What are the differences between
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the Improved Footnote Serialization in MarkdownDocSerializer.
It is a Feature Request submitted by simonschoe in docling-project.
The features added include serializing a footnote in the form
[^{Identifier}]: {Description}. This is done for Table and Picture items, as footnotes are linked to those.In general, footnotes in
.mdfiles should look like:Tests Added: