Skip to content

chore: parametrize validation through context #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vagenas wants to merge 1 commit into from
+12 −1
Closed

chore: parametrize validation through context #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion docling_core/types/doc/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
FieldSerializationInfo,
SerializerFunctionWrapHandler,
StringConstraints,
ValidationInfo,
computed_field,
field_serializer,
field_validator,
Expand Down Expand Up @@ -5643,6 +5644,9 @@ def save_as_json(
with open(filename, "w", encoding="utf-8") as fw:
json.dump(out, fw, indent=indent)

class _ValidationContext(BaseModel):
validate_ref_bidir: bool = True # whether to validate reference bidirectionality

@classmethod
def load_from_json(cls, filename: Union[str, Path]) -> "DoclingDocument":
"""load_from_json.
Expand Down Expand Up @@ -7074,7 +7078,6 @@ def _normalize_table_children_from_rich_cells(self):
table.children.append(cell.ref)
child_crefs.add(cell.ref.cref)

@model_validator(mode="after")
def validate_document(self) -> Self:
"""validate_document."""

Expand All @@ -7086,6 +7089,14 @@ def validate_document(self) -> Self:

return self

@model_validator(mode="after")
def _validate_document(self, info: ValidationInfo) -> Self:
ctx = self._ValidationContext.model_validate(info.context or {})
if ctx.validate_ref_bidir:
return self.validate_document()
else:
return self

@model_validator(mode="after")
def validate_misplaced_list_items(self) -> Self:
"""validate_misplaced_list_items."""
Expand Down
Loading