Skip to content

fix: restore floating-item footnotes in markdown/html exports#545

Open
M-Hassan-Raza wants to merge 2 commits intodocling-project:mainfrom
M-Hassan-Raza:fix/floating-item-footnotes
Open

fix: restore floating-item footnotes in markdown/html exports#545
M-Hassan-Raza wants to merge 2 commits intodocling-project:mainfrom
M-Hassan-Raza:fix/floating-item-footnotes

Conversation

@M-Hassan-Raza
Copy link
Copy Markdown

@M-Hassan-Raza M-Hassan-Raza commented Mar 15, 2026

Closes #496.

This restores floating-item footnotes in Markdown export and fixes the same shared path for HTML and chunking.

The main change is that footnotes now go through the normal text serializer, so formatting and hyperlinks are preserved instead of being flattened to plain text. I also tightened the HTML output a bit so footnotes render as a grouped note block alongside the related table or figure.

Tests:

  • uv run pytest -q test/test_serialization.py test/test_docling_doc.py
  • uv run --extra chunking pytest -q test/test_hierarchical_chunker.py test/test_hybrid_chunker.py
  • uv run ruff check docling_core/transforms/serializer/common.py docling_core/transforms/serializer/markdown.py docling_core/transforms/serializer/html.py docling_core/transforms/chunker/hierarchical_chunker.py test/test_serialization.py test/test_hierarchical_chunker.py

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2026

DCO Check Passed

Thanks @M-Hassan-Raza, all your commits are properly signed off. 🎉

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 15, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@M-Hassan-Raza M-Hassan-Raza force-pushed the fix/floating-item-footnotes branch 3 times, most recently from 8e9d4cb to b5dc1ee Compare March 15, 2026 20:49
Signed-off-by: Hassan Raza <raihassanraza10@gmail.com>
@M-Hassan-Raza M-Hassan-Raza force-pushed the fix/floating-item-footnotes branch from b5dc1ee to be81d87 Compare March 15, 2026 20:49
Signed-off-by: Hassan Raza <raihassanraza10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Table footnotes missing from markdown serialization after commit dda9c88

1 participant