fix: convert headings to plain text in table cells (issue #2722)#540
Open
mikemikimike wants to merge 2 commits intodocling-project:mainfrom
Open
fix: convert headings to plain text in table cells (issue #2722)#540mikemikimike wants to merge 2 commits intodocling-project:mainfrom
mikemikimike wants to merge 2 commits intodocling-project:mainfrom
Conversation
Contributor
|
✅ DCO Check Passed Thanks @mikemikimike, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: 温可 <wenke@openclaw.ai>
mikemikimike
force-pushed
the
fix/2722-table-heading
branch
from
e919759 to
9a64509
Compare
I, 温可 <wenke@openclaw.ai>, hereby add my Signed-off-by to this commit: 9a64509 Signed-off-by: 温可 <wenke@openclaw.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to markdown specs, headings are not allowed inside tables. This fix converts markdown headings to plain text when rendering content inside table cells.
Fix
In MarkdownTextSerializer.serialize(), added in_table_cell parameter. The _format_heading() method now checks this flag and returns plain text instead of markdown headings when rendering inside table cells.
Issue
Fixes #2722