Update DMR integration to new Compose integration#13
Merged
ericcurtin merged 3 commits intomainfrom Oct 9, 2025
Merged
Conversation
…CI smoke tests - Remove run.sh script and .env file - Update README.md to use Docker Compose directly - Replace root docker-compose.yml with include directive - Add individual docker-compose.yml files for each service - Configure consistent port mapping (8080 internal, 8080-8083 external) - Update all services to use LLAMA_URL/LLAMA_MODEL env vars only - Add health endpoint to Node.js service - Add GitHub Actions workflow with Docker Model Plugin integration - Remove dotenv dependency from Node.js project BREAKING CHANGE: services now require Docker Model Runner instead of .env file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Combine service startup and testing into single step to keep processes alive - Remove redundant environment variables from workflow (use Compose file config) - Wait for health check before running tests in same execution context
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GenAI applications to use the new Docker Model Runner (DMR) Compose integration, replacing the previous manual environment variable configuration. The update simplifies deployment by leveraging DMR's automatic service discovery and model management capabilities.
- Replaces legacy
LLM_BASE_URLandLLM_MODEL_NAMEenvironment variables with DMR-injectedLLAMA_URLandLLAMA_MODEL - Adds individual Docker Compose files for each service with DMR model configuration
- Includes a GitHub Actions workflow for smoke testing and DMR demonstration
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-genai/src/config.rs | Updates config to prioritize DMR variables with legacy fallback |
| rust-genai/docker-compose.yaml | Adds DMR model configuration and updates port mapping |
| run.sh | Removes legacy Docker model pull script |
| py-genai/docker-compose.yml | New DMR-enabled compose file for Python service |
| py-genai/app.py | Updates to use DMR environment variables |
| node-genai/package.json | Removes dotenv dependency (no longer needed) |
| node-genai/docker-compose.yml | New DMR-enabled compose file for Node.js service |
| node-genai/app.js | Updates to use DMR variables and removes env file logic |
| go-genai/main.go | Updates configuration loading to use DMR variables |
| go-genai/docker-compose.yml | New DMR-enabled compose file for Go service |
| docker-compose.yml | Simplifies to include individual service compose files |
| README.md | Updates setup instructions for new compose structure |
| .github/workflows/smoke-tests.yml | Adds comprehensive smoke testing workflow |
| .env | Removes legacy environment configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ericcurtin
approved these changes
Oct 9, 2025
doringeman
reviewed
Oct 9, 2025
| - "8082:8080" | ||
| environment: | ||
| - PORT=8080 | ||
| x-genai-models: |
Contributor
There was a problem hiding this comment.
Why the x-genai- prefix?
Member
Author
There was a problem hiding this comment.
lol no clue TBH, I did this some time ago and I guess Claude came up with it, or maybe back then it was even needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new DMR Compose integration.
Also add a GHA workflow to act as a smoke test and demonstrate DMR usage on GHA.
Fixes #7
Fixes #11