-
Notifications
You must be signed in to change notification settings - Fork 846
gha: Add diff and deploy #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Curious if there's be ways to keep anything "deploy" to internal repositories (without it being cumbersome); mostly trying to avoid public repositories having access to secrets, but not sure if there's a good way. Would it be possible to have an internal flow subscribe to merges (e.g.)? Maybe @crazy-max has fancy ideas. (That's not a "no", just "are there options for this?", as these secrets might give access to critical bits). |
|
Only the ID of the S3 buckets and the cloudfront distribution IDs are stored as repo secrets, but these aren't really sensitive, it's more of a security-by-obscurity. The actual AWS credentials are obtained dynamically via OIDC and they're only accessible from the We could make merge notify an internal repo and run the workflow there if we really want. Not sure if we really need though. |
|
这是一封自动回复邮件。已经收到您的来信,我会尽快回复。
translation: "This is an automatic reply email. I have received your letter, and I will reply as soon as possible." 😅
|
|
Ok, fine, let's move it to internal 😅 |
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming kevin reviewed 😂
'LGTM"
Add scripts that will be used by https://github.com/docker/docker-install-deploy to deploy the script.