Avoid installing missing packages for version 23 (and moving them to 28.2)

[rejeangroleau]

On ubuntu bionic and some other debian/versions, the docker-model-plugin package is missing. The suggestion was to just install the package named docker-buildx-plugin in the version 23 check, while moving the missing package docker-model-plugin to a new "version 28.2" check.

See: #509

[vvoland]

Thanks! Left some comments

[vvoland]

This seems to be inside the RPM-based block, it needs to go in:

docker-install/install.sh

Lines 549 to 558 in 7040dd2

	if version_gte "18.09"; then
	# older versions didn't ship the cli and containerd as separate packages
	pkgs="$pkgs docker-ce-cli${cli_pkg_version%=} containerd.io"
	fi
	if version_gte "20.10"; then
	pkgs="$pkgs docker-compose-plugin docker-ce-rootless-extras$pkg_version"
	fi
	if version_gte "23.0"; then
	pkgs="$pkgs docker-buildx-plugin docker-model-plugin"
	fi

[rejeangroleau]

@vvoland I just move it (from line 600-something to line 557). But I can also use your "version 28" approach if you want me to.

[vvoland]

Tbh, I think we can make our life easier and only consider model plugin from 28.0+ up. (buildx still 23.0)

[vvoland]

cc @doringeman

[rejeangroleau]

@vvoland I agree, ok, so would you like me to just replace the "new" switch case by just an additional if version_gte "28.0" that contains just the model plugin (while keeping just the buildx plugin in the "if 23" section)? I could do that. Not sure if v28 is availble for me to test right now though.

[vvoland]

That's correct!

For testing purposes, you can use whatever version_gte X you want, just make sure to change it before pushing :)

[rejeangroleau]

@vvoland Ok I did just that, and I used @thaJeztah suggestion of version 27 (but if you would rather use version 28 I can do that too).

[vvoland]

Works for me. This is a best-effort check anyway 👍🏻

[vvoland]

Also, we should avoid having to maintain this list of distros. We definitely don't want to end up having adding each new distro to the list.
We should default to installing all plugins (after a version check), and then only disable for the distros we know that are not supported.

[thaJeztah]

I'm a bit on the fence on this; we're adding complexity for EOL distros that the script no longer maintains; perhaps instead we need to make the deprecation warning a hard failure instead;

curl -fsSL https://get.docker.com | DRY_RUN=1 sh
# Executing docker install script, commit: 7040dd2bf115a359317b1de84de611aeabcb7bc2

DEPRECATION WARNING
    This Linux distribution (ubuntu bionic) reached end-of-life and is no longer supported by this script.
    No updates or security fixes will be released for this distribution, and users are recommended
    to upgrade to a currently maintained version of ubuntu.

Press Ctrl+C now to abort this script, or wait for the installation to continue.
^C

Alternatively, we could make the model plugin conditional on version, and only install on current version(s) (e.g., 27.x and up), although strictly speaking, the plugin doesn't depend on those versions, and could be installed on older versions;

docker-install/install.sh

Lines 658 to 660 in 7040dd2

	if version_gte "23.0"; then
	pkgs="$pkgs docker-buildx-plugin docker-model-plugin"
	fi

[vvoland]

DCO is needed: https://github.com/docker/docker-install/pull/511/checks?check_run_id=45953829168

[vvoland]

LGTM after DCO

[rejeangroleau]

I found an easy way to test if this works using docker containers (instead of EC2 machines or other VM types):
command (running inside the folder where the docker-install repo was cloned):

docker run -v $(pwd):/docker-install ubuntu:18.04 /docker-install/install.sh

output:

# Executing docker install script, commit: 

DEPRECATION WARNING
    This Linux distribution (ubuntu bionic) reached end-of-life and is no longer supported by this script.
    No updates or security fixes will be released for this distribution, and users are recommended
    to upgrade to a currently maintained version of ubuntu.

Press Ctrl+C now to abort this script, or wait for the installation to continue.
+ sh -c apt-get -qq update >/dev/null
+ sh -c DEBIAN_FRONTEND=noninteractive apt-get -y -qq install ca-certificates curl >/dev/null
debconf: delaying package configuration, since apt-utils is not installed
+ sh -c install -m 0755 -d /etc/apt/keyrings
+ sh -c curl -fsSL "https://download.docker.com/linux/ubuntu/gpg" -o /etc/apt/keyrings/docker.asc
+ sh -c chmod a+r /etc/apt/keyrings/docker.asc
+ sh -c echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu bionic stable" > /etc/apt/sources.list.d/docker.list
+ sh -c apt-get -qq update >/dev/null
+ sh -c DEBIAN_FRONTEND=noninteractive apt-get -y -qq install docker-ce docker-ce-cli containerd.io docker-compose-plugin docker-ce-rootless-extras docker-buildx-plugin docker-model-plugin >/dev/null
E: Unable to locate package docker-model-plugin

So yeah without a --version, the script still fails (so older CI/CD pipelines will still have to be adjusted to add a --version statement).

But with the command:

docker run -v $(pwd):/docker-install ubuntu:18.04 /docker-install/install.sh --version 23.0

output:

# Executing docker install script, commit: 

DEPRECATION WARNING
    This Linux distribution (ubuntu bionic) reached end-of-life and is no longer supported by this script.
    No updates or security fixes will be released for this distribution, and users are recommended
    to upgrade to a currently maintained version of ubuntu.

Press Ctrl+C now to abort this script, or wait for the installation to continue.
+ sh -c apt-get -qq update >/dev/null
+ sh -c DEBIAN_FRONTEND=noninteractive apt-get -y -qq install ca-certificates curl >/dev/null
debconf: delaying package configuration, since apt-utils is not installed
+ sh -c install -m 0755 -d /etc/apt/keyrings
+ sh -c curl -fsSL "https://download.docker.com/linux/ubuntu/gpg" -o /etc/apt/keyrings/docker.asc
+ sh -c chmod a+r /etc/apt/keyrings/docker.asc
+ sh -c echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu bionic stable" > /etc/apt/sources.list.d/docker.list
+ sh -c apt-get -qq update >/dev/null
INFO: Searching repository for VERSION '23.0'
INFO: apt-cache madison docker-ce | grep '23.0' | head -1 | awk '{$1=$1};1' | cut -d' ' -f 3
INFO: apt-cache madison docker-ce-cli | grep '23.0' | head -1 | awk '{$1=$1};1' | cut -d' ' -f 3
+ sh -c DEBIAN_FRONTEND=noninteractive apt-get -y -qq install docker-ce=5:23.0.6-1~ubuntu.18.04~bionic docker-ce-cli=5:23.0.6-1~ubuntu.18.04~bionic containerd.io docker-compose-plugin docker-ce-rootless-extras=5:23.0.6-1~ubuntu.18.04~bionic docker-buildx-plugin >/dev/null
debconf: delaying package configuration, since apt-utils is not installed

================================================================================

To run Docker as a non-privileged user, consider setting up the
Docker daemon in rootless mode for your user:

    dockerd-rootless-setuptool.sh install

Visit https://docs.docker.com/go/rootless/ to learn about rootless mode.


To run the Docker daemon as a fully privileged service, but granting non-root
users access, refer to https://docs.docker.com/go/daemon-access/

WARNING: Access to the remote API on a privileged Docker daemon is equivalent
         to root access on the host. Refer to the 'Docker daemon attack surface'
         documentation for details: https://docs.docker.com/go/attack-surface/

================================================================================

Now this works fine. So it looks like this PR modification has the intended effect to only install docker-buildx-plugin (not docker-model-plugin anymore) when specifying --version 23.0 with success.

I also tested with --version 27.0 but obviously that is not yet available of course:

INFO: Searching repository for VERSION '27.0'
INFO: apt-cache madison docker-ce | grep '27.0' | head -1 | awk '{$1=$1};1' | cut -d' ' -f 3

ERROR: '27.0' not found amongst apt-cache madison results

I will test the other distros too later today (using the same docker commands). Just brainstorming here: could we put that test in an automated github CI/CD pipeline? Maybe that would be too costly.

[rejeangroleau]

So I tested with: docker run -v $(pwd):/docker-install quay.io/centos/centos:stream9 /docker-install/install.sh and it works just fine (already did before this PR: docker-model-plugin is available for this distro version).

Then I tested with ubuntu:22.04 and it also works great.

Then I tested with ubuntu:24.04 and it also works great.

Lastly, I thought I would test ubuntu:20.04 and I realised: there is a small problem that we could address.

This distro version 20.04 supports docker version 27, even version 28, but does not contain the docker-model-plugin associated with it. It looks like the docker-model-plugin was released with version 28.2 (and ubuntu:20.04 stopped having new docker versions at 28.1).

So maybe I could change the if condition to version_gte 28.2 to support ubuntu:20.04 too, what do you think @vvoland? Would that be overkill?

[vvoland]

It's fine IMO. It's only a default anyway, and user can always do explicit installation of the model plugin.

[thaJeztah]

Yes, changing to version_gte 28.2 sounds good to me. I originally added it to version_gte 23.0 with the idea that any of those versions would be recent enough to support plugins, but did not account for some distros on those versions to not have the plugin package available. This was mostly to "opportunistically" install docker model because some people asked "can I have docker model on my machine?".

I guess it's fine to just do it by default on v28.2 (or "latest") as installing "latest version" would be the most common case for users to install using this script

[thaJeztah]

LGTM, thanks!

[thaJeztah]

@vvoland PTAL

[vvoland]

LGTM, thanks!