gha: Add workflow to test rootless install #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
force-pushed
the
test-rootless-install
branch
2 times, most recently
from
9093f9d to
737b898
Compare
vvoland
commented
Apr 17, 2025
.github/workflows/ci.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Rootless install | ||
| run: FORCE_ROOTLESS_INSTALL=1 ./rootless-install.sh |
Contributor
Author
There was a problem hiding this comment.
This is a separate workflow step, because we need to check it outside of container (due to lsmod, iptables checks)
Member
There was a problem hiding this comment.
Is it worth adding a comment for that? (i.e. why we need to do separate)
vvoland
changed the title
Contributor
Author
|
Fails as expected because it's before: #487 Will rebase it after a merge and it should become green. |
vvoland
force-pushed
the
test-rootless-install
branch
5 times, most recently
from
c4094d1 to
ad4a61b
Compare
robmry
approved these changes
Apr 17, 2025
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
test-rootless-install
branch
from
ad4a61b to
5c96993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the rootless install in CI