Skip to content

Conversation

@dnephin
Copy link
Contributor

@dnephin dnephin commented Jan 18, 2018

Closes #767

Add a new Dockerfile, and docker.Makefile target for building on other platforms that require additional dependencies.

make -f docker.Makefile binary

cc @seemethere @arm64b

@codecov-io
Copy link

codecov-io commented Jan 18, 2018

Codecov Report

Merging #816 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   51.23%   51.23%           
=======================================
  Files         237      237           
  Lines       15399    15399           
=======================================
  Hits         7889     7889           
  Misses       7008     7008           
  Partials      502      502

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin
Copy link
Contributor Author

dnephin commented Jan 18, 2018

@vdemeester brought up a good point, the old binary target is actually not necessary anymore, so instead of adding a new target I've just replaced the old one.

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

Copy link
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arm64b
Copy link

arm64b commented Jan 19, 2018

Thanks for the support 😄

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit b6a628c into docker:master Jan 23, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.02.0 milestone Jan 23, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Add dockerfile for building on non-amd64 platforms
Upstream-commit: b6a628c
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants