-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add dockerfile for building on non-amd64 platforms #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
=======================================
Coverage 51.23% 51.23%
=======================================
Files 237 237
Lines 15399 15399
=======================================
Hits 7889 7889
Misses 7008 7008
Partials 502 502 |
Signed-off-by: Daniel Nephin <dnephin@docker.com>
e9d0d8f to
02ca1c8
Compare
|
@vdemeester brought up a good point, the old |
vdemeester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦁
seemethere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the support 😄 |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect.
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add dockerfile for building on non-amd64 platforms Upstream-commit: b6a628c Component: cli
Closes #767
Add a new
Dockerfile, anddocker.Makefiletarget for building on other platforms that require additional dependencies.cc @seemethere @arm64b