Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 16, 2018

carry of #752, fixing the sign-off

closes #752

Signed-off-by: Taylor Brown <taylorb@microsoft.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@dnephin
Copy link
Contributor

dnephin commented Jan 16, 2018

opened #813 for flaky test

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #812 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   51.12%   51.12%           
=======================================
  Files         237      237           
  Lines       15366    15366           
=======================================
  Hits         7856     7856           
  Misses       7008     7008           
  Partials      502      502

@thaJeztah thaJeztah merged commit 44094b5 into docker:master Jan 16, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.02.0 milestone Jan 16, 2018
@thaJeztah thaJeztah deleted the fix-builder-quote branch January 16, 2018 22:15
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Fix stray quote in builder.md
Upstream-commit: 44094b5
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants