use 'config' over 'configuration file' #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
======================================
Coverage 50.9% 50.9%
======================================
Files 237 237
Lines 15338 15338
======================================
Hits 7808 7808
Misses 7028 7028
Partials 502 502 |
dnephin
reviewed
Jan 4, 2018
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
SGTM
one nit on wording for create
cli/command/config/create.go
Outdated
| cmd := &cobra.Command{ | ||
| Use: "create [OPTIONS] CONFIG file|-", | ||
| Short: "Create a configuration file from a file or STDIN as content", | ||
| Short: "Create config using a file or STDIN as content", |
Contributor
There was a problem hiding this comment.
How about:
"Create a config from a file or STDIN"
vdemeester
approved these changes
Jan 5, 2018
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 😛
cc @thaJeztah
Signed-off-by: Michael Friis <friism@gmail.com>
friism
force-pushed
the
make-config-wording-more-consistent
branch
from
fc8eb74 to
99e3b4c
Compare
Contributor
Author
|
squashed, thanks guys |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
…nsistent use 'config' over 'configuration file' Upstream-commit: a60bdf3 Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The help text for
configcommands is not consistent about whether the object being modified is called a "config" or a "configuration file". I changed it to be "config" for all commands since that's shorter.Previously:
- How to verify it
docker config --help- Description for the changelog
Descriptions for config commands now use the same name when describing configs.